Skip to content

fix: fix sign-in parameter identifier #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix sign-in parameter identifier #34

wants to merge 1 commit into from

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Nov 26, 2024

Summary

  1. Sign-in URL query parameter should be "identifier" not "identifiers"
  2. sign-in parameter "identifiers" should be serialized string array

Testing

Tested locally.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@darcyYe darcyYe requested a review from gao-sun November 26, 2024 10:29
@darcyYe darcyYe changed the title fix: fix sign-in parameter 'identifier' fix: fix sign-in parameter identifier Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gao-sun gao-sun Awaiting requested review from gao-sun

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@darcyYe